Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 12, 2026

On the Vue 3 side lets remove the dependency on Moment as this is a pretty huge dependency. Instead use something tiny like dayjs for date computation (end of week / end of day) and use plain Intl API for formatting.

This reduces the bundle size by 9%.

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Jan 12, 2026
@susnux susnux requested a review from ShGKme January 12, 2026 20:38
@susnux susnux requested review from a team as code owners January 12, 2026 20:38
@susnux susnux added 3. to review Waiting for reviews dependencies labels Jan 12, 2026
@susnux susnux requested review from nfebe and szaimen and removed request for a team January 12, 2026 20:38
@susnux susnux added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Jan 12, 2026
@susnux susnux requested review from sorbaugh and removed request for a team January 12, 2026 20:38
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux force-pushed the chore/drop-moment branch from 3f79e79 to 48a0a1f Compare January 13, 2026 10:14
@susnux susnux requested a review from ShGKme January 13, 2026 10:15
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 12, 2026
On the Vue 3 side lets remove the dependency on Moment as this is a
pretty huge dependency. Instead use plain Intl API for formatting.

This reduces the bundle size by ~1.5MiB.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the chore/drop-moment branch from 48a0a1f to a623bff Compare January 14, 2026 09:27
@susnux susnux merged commit 22ebf79 into master Jan 14, 2026
146 of 150 checks passed
@susnux susnux deleted the chore/drop-moment branch January 14, 2026 11:33
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 14, 2026
asavageiv added a commit to asavageiv/tasks that referenced this pull request Jan 19, 2026
Following nextcloud/server#57503, this saves about 15%
of the zipped bundle size for Tasks.

Signed-off-by: Alan Savage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies performance 🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants